Dataset doc updated #27933
Merged
Dataset doc updated #27933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimsa
requested changes
Apr 17, 2019
| ``` | ||
|
|
||
| The input signature of `map_func` is determined by the structure of each | ||
| element in this dataset. For example: | ||
|
|
||
| ```python | ||
| # NOTE: The following examples use `{ ... }` to represent the |
There was a problem hiding this comment.
why do you introduce this comment here? I thought the purpose of this PR was to replace { ... } with code that runs
There was a problem hiding this comment.
There are several examples following line in line 944 - 961 that I didn't change in this request and still contain non executable code. I wanted to keep this request small because I expected some feedback. I'll take another look in a separate request.
jsimsa
approved these changes
Apr 18, 2019
rthadur
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Apr 18, 2019
PiperOrigin-RevId: 244259677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on issue #25320. This pull request clarifies the documentation by adding runnable code for several methods of the Dataset class (zip, concatenate, interleave, map, flat_map)
@mrry @jsimsa